Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): Add metering example #1867

Merged
merged 3 commits into from
Dec 4, 2020
Merged

feat(examples): Add metering example #1867

merged 3 commits into from
Dec 4, 2020

Conversation

jubianchi
Copy link
Contributor

@jubianchi jubianchi commented Dec 3, 2020 •
edited
Loading

To DO

  • How to use metering in a module
  • How to meter a function call (see cost of gas before and after)
  • Demonstrate that if the gas is over the given limit, it should fail.

Review

  • Add a short description of the the change to the CHANGELOG.md file

@jubianchi jubianchi self-assigned this Dec 3, 2020
Hywan
Hywan reviewed Dec 3, 2020
View reviewed changes
examples/metering.rs Outdated Show resolved Hide resolved
@Hywan Hywan changed the title feat:(examples): Add metering example feat(examples): Add metering example Dec 3, 2020
syrusakbary
syrusakbary reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metering example should show:

  1. How to use metering in a module (done)
  2. How to meter a function call (see cost of gas before and after)
  3. Demonstrate that if the gas is over the given limit, it should fail.

@jubianchi jubianchi marked this pull request as ready for review December 4, 2020 07:48
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 4, 2020
@bors @jubianchi
Merge #1867
ff693dc 
1867: feat(examples): Add metering example r=syrusakbary a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <julien@wasmer.io>
@jubianchi
Copy link
Contributor Author

bors r-

@bors
Copy link
Contributor

bors bot commented Dec 4, 2020

Canceled.

@jubianchi jubianchi added the 1.0 Wasmer at 1.0 label Dec 4, 2020
jubianchi
jubianchi commented Dec 4, 2020
View reviewed changes
examples/metering.rs Outdated Show resolved Hide resolved
@jubianchi
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 4, 2020

Build succeeded:

@bors bors bot merged commit 4801700 into master Dec 4, 2020
@bors bors bot deleted the examples/metering branch December 4, 2020 17:21
@syrusakbary syrusakbary mentioned this pull request Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees

@jubianchi jubianchi

Labels
1.0 Wasmer at 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jubianchi @syrusakbary @Hywan